I've used loads, but probably the best from a reliability perspective has been the old Star Cursor. Australian made, fully microswitched, wiring is totally straightforward making it perfectly repairable. Not the most comfortable thing ever mind you... I have two of them. One works great, the other needs a couple of new microswitches to have it back to 100%.
Otherwise, I've got the SVI Quickshot IX (awful), the SVI Quickshot QS-131 (average), some weird SVI thing that looks more like a stopwatch than a controller (self explanatory), a Battlestation II (HUGE and AWESOME) and a heavily modified Quickshot Professional arcade stick (not very professional or arcade). It was originally fitted with two cables and was meant for sharing between two people, had a switch for moving between Atari/Commodore/etc mode, MSX, Master System yada yada but all that part died so the PCB has been cut and modified to make it a standard two button joystick.
Realistically if I was going for the best thing ever, it'd be the Battlestation's sticks and buttons in a single user package. You can't argue with real arcade hardware.
Just the local Commodore hobo and middle-aged PC hoarder.
eisa on Trademe. A lasting reminder of a Compaq fetish when I was younger.